Add unique name for parameterized prepared statements #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the fastest node.js hashing algorithm : https://medium.com/@chris_72272/what-is-the-fastest-node-js-hashing-algorithm-c15c1a0e164e |
|
@tshemsedinov check please |
| @@ -1,6 +1,9 @@ | |||
| 'use strict'; | |||
|
|
|||
| const { Pool } = require('pg'); | |||
| const createHash = require('node:crypto').createHash; | |||
|
|
|||
| const hash = (data) => createHash('sha1').update(data).digest('base64'); | |||
There was a problem hiding this comment.
Consider move to metautil or local submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing Unique Naming for Parameterized Prepared Statements
The Pg module consistently utilizes prepared statements for parameterized queries, even when a name isn't explicitly provided. To enhance this process, I have implemented a custom name generator based on the crypto SHA1 algorithm, known for its speed. This is particularly beneficial in applications where SQL queries are frequently repeated with varying parameters. This improvement aims to streamline operations by reducing the number of additional database queries.
npm t)npm run fmt)